Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back lost local storage code #2586

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Add back lost local storage code #2586

merged 5 commits into from
Nov 20, 2023

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Nov 17, 2023

Proposed changes

Added back lost local storage code, this should allow local storage to be used again and the migration script to kick in for vscode settings of persistent items to move to local storage, this means the history view should behave just like v2 does but with local storage behind the scenes!

Release Notes

Milestone: v3 pre-releases

Changelog: Added back local storage for Zowe Explorer persistent items

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores rudyflores added this to the v3 pre-releases milestone Nov 17, 2023
@rudyflores rudyflores self-assigned this Nov 17, 2023
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores
Copy link
Contributor Author

Reminder: to open history view with shorcut in next branch the shorctut is still ctrl/cmd+Y until we merge main into next with the fixes from v2.12.1 and v2.12.2

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bad405c) 93.03% compared to head (bd6d658) 93.07%.
Report is 4 commits behind head on next.

❗ Current head bd6d658 differs from pull request most recent head 373c897. Consider uploading reports for the commit 373c897 to get more accurate results

Files Patch % Lines
packages/zowe-explorer/src/utils/LoggerUtils.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2586      +/-   ##
==========================================
+ Coverage   93.03%   93.07%   +0.04%     
==========================================
  Files         108      108              
  Lines        9807     9806       -1     
  Branches     2028     2028              
==========================================
+ Hits         9124     9127       +3     
+ Misses        682      678       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rudyflores for adding back the local storage in the next branch. I did push some commits removing the carets on zowe product dependencies to avoid issues with mismatch dep for ourselves and extenders.
I would like to see the imperative dep removed from a sample since we added the export to ZE API, I can work on it 😄
Also, I pushed the change adding TBD Release to the CHANGELOGs and the CHANGELOG check passes, so no issue with this script just need to fix the deployment and get it adding this back after release.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this back!
I'm curious how this got lost in the first place.
(Likely an oversight of mine 😓)

Either way, LGTM! 😋

@JillieBeanSim JillieBeanSim merged commit 5f84872 into next Nov 20, 2023
16 checks passed
@JillieBeanSim JillieBeanSim deleted the add-back-local-storage branch November 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants