feat(extender): Expose and reuse login and logout methods

[zFernand0]

Proposed changes

Expose the login and logout methods to extenders

Release Notes

Milestone: 2.14.0

Changelog: Exposed the login and logout methods to extenders

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

There is a dependency on the PR below:

• feat(imperative): Enhanced ProfileInfo.updateProperty zowe-cli#1983

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (fa19be7) 93.32% compared to head (40c6f13) 93.30%.

Files	Patch %	Lines
packages/zowe-explorer/src/Profiles.ts	75.00%	5 Missing ⚠️
...owe-explorer-api/src/vscode/ZoweVsCodeExtension.ts	95.08%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
- Coverage   93.32%   93.30%   -0.02%     
==========================================
  Files         102      102              
  Lines       10501    10546      +45     
  Branches     2250     2278      +28     
==========================================
+ Hits         9800     9840      +40     
- Misses        700      705       +5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JillieBeanSim]

Hey @zFernand0, thanks for this new extender functionality. As regression testing with an extender that logs into it own rest api worked fine but when I tried with zosmf / apiml combo I got this error that I don't see with released ZE using same profile

[JillieBeanSim]

further info for recreation steps of getting the error:

have team config with zosmf & base profile similar to below:
"apimlzosmf": {
"type": "zosmf",
"properties": {
"port": 7554,
"basePath": "ibmzosmf/api/v1"
},
"secure": []
},
"base": {
"type": "base",
"properties": {
"host": "host.com",
"rejectUnauthorized": false
},
"secure": []
}

On this branch I get the error above logging in, but works fine using the released ZE from marketplace saving the tokenType & tokenValue to the base profile.

[zFernand0]

Hey @zFernand0, thanks for this new extender functionality. As regression testing with an extender that logs into it own rest api worked fine but when I tried with zosmf / apiml combo I got this error that I don't see with released ZE using same profile

This PR will fix the issue 😋

• fix(profInfo): Fixed property not found issue in forceUpdate functionality zowe-cli#2014

[JillieBeanSim]

thanks @zFernand0, can re-request review once pulling in those dep updates.

[zFernand0]

Note:

• The version that contains the fix for this PR is @zowe/cli@7.21.4
• This also contains the updates in @zowe/cli@7.21.3 made by @KevinLoesch1
  • These updates fix blksz to 0 after an Allocate Like #2610,
    Thanks Kevin!

[zFernand0]

The Lint failures seem unrelated since those were working before updating from main

• https://github.com/zowe/vscode-extension-for-zowe/actions/runs/7201520591/job/19617824160

Updated CLI version 😋

[traeok]

Logic looks good! Going to test shortly. Thanks @zFernand0!
In the meantime, I think I found the source of the lint stage failure - I added comments for those lines.

[t1m0thyj]

Looks pretty good, thanks @zFernand0 😺

When testing this PR, I noticed there is text pre-filled in the input boxes for user/password. I think we want to retain the previous behavior of placeholder values that are "grayed out".

Before

After


(here I have not entered a password yet, but it is trying to show "Password" which renders as dots)

Unexpected behavior was corrected 😋

[sonarqubecloud]

Quality Gate failed

Failed conditions

7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[JillieBeanSim]

LGTM! thanks @zFernand0 for this update

[zFernand0]

LGTM! thanks zFernand0 for this update

Thank you, @JillieBeanSim for updating the package i18n 😋

[traeok]

LGTM! Thanks @zFernand0

[zFernand0]

The code duplication seems to be on new tests added.
Thanks for reviewing! 😋
Merging!