-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 'Copy Relative Path' for USS, 'Copy Name' for DS & Jobs #2908
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
+ Coverage 93.46% 93.48% +0.01%
==========================================
Files 104 104
Lines 10841 10869 +28
Branches 2361 2264 -97
==========================================
+ Hits 10133 10161 +28
Misses 707 707
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @traeok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the enhancement! 🙏🏽
Curious if we can limit the Job label to just the Jobname(Jobid)
(instead of the name(id) - SYSTEM | ACTIVE [ - CC ]
) 😅
I'm still approving because I agree that this can be enhanced in the future 😋
LGTM! 😋
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Thanks for the suggestion! I've pushed up commit 23e66bc that will return that format for jobs with valid job objects 😋 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for addressing the feedback so quickly! 🥳
For spool-files, I don't think people will need the job name or id to be there as prefix 😋
I think just having JES:JESMSGLG is probably more than enough 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Proposed changes
Implements three features:
/z/testUser/file.txt
and the search filter is set to/z/testUser
, it will return "file.txt"SOME.PDS(MEMNAME)
Release Notes
Milestone: 2.17.0
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed