Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'Copy Relative Path' for USS, 'Copy Name' for DS & Jobs #2908

Merged
merged 6 commits into from
May 13, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented May 8, 2024

Proposed changes

Implements three features:

  • "Copy Relative Path" for USS files and directories
    • "relative" meaning relative to the search filter that's been set on the profile node. For example, if the full path for a file is /z/testUser/file.txt and the search filter is set to /z/testUser, it will return "file.txt"
  • "Copy Name" for DS, PDS, PDS members and migrated DS
    • PDS members will return the format SOME.PDS(MEMNAME)
  • "Copy Name" for jobs and spool files
    • Currently this just returns the label of the node, we can enhance this in the future if needed. Most of the interest was expressed for USS and DS

Release Notes

Milestone: 2.17.0

Changelog:

  • Added a "Copy Relative Path" context option for USS files and directories in the tree view. #2908
  • Added a "Copy Name" context option for data sets, jobs and spool files in the tree view. #2908

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok added 2 commits May 8, 2024 14:12
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (7995b02) to head (23e66bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
+ Coverage   93.46%   93.48%   +0.01%     
==========================================
  Files         104      104              
  Lines       10841    10869      +28     
  Branches     2361     2264      -97     
==========================================
+ Hits        10133    10161      +28     
  Misses        707      707              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

traeok added 2 commits May 8, 2024 14:17
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
anaxceron
anaxceron previously approved these changes May 8, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @traeok

zFernand0
zFernand0 previously approved these changes May 9, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the enhancement! 🙏🏽
Curious if we can limit the Job label to just the Jobname(Jobid) (instead of the name(id) - SYSTEM | ACTIVE [ - CC ]) 😅

I'm still approving because I agree that this can be enhanced in the future 😋

LGTM! 😋

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok dismissed stale reviews from zFernand0 and anaxceron via 23e66bc May 9, 2024 14:32
@traeok traeok requested a review from zFernand0 May 9, 2024 14:33
@traeok
Copy link
Member Author

traeok commented May 9, 2024

Love the enhancement! 🙏🏽 Curious if we can limit the Job label to just the Jobname(Jobid) (instead of the name(id) - SYSTEM | ACTIVE [ - CC ]) 😅

Thanks for the suggestion! I've pushed up commit 23e66bc that will return that format for jobs with valid job objects 😋

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋


Thanks for addressing the feedback so quickly! 🥳

For spool-files, I don't think people will need the job name or id to be there as prefix 😋
I think just having JES:JESMSGLG is probably more than enough 😋

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

@JillieBeanSim JillieBeanSim added this to the v2.17.0 milestone May 13, 2024
@JillieBeanSim JillieBeanSim merged commit 4ad11e9 into main May 13, 2024
20 checks passed
@JillieBeanSim JillieBeanSim deleted the feat/copy-rel-path branch May 13, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants