Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with clearing profile object caches on refresh #2917

Merged
merged 2 commits into from
May 16, 2024

Conversation

t1m0thyj
Copy link
Member

Proposed changes

Fixes #2910

Release Notes

Milestone:

Changelog: Fixed regression of issue where the ProfilesCache class would retain old service profiles, even if they were removed from the team config

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (0e7feac) to head (fa5d491).

Additional details and impacted files
@@             Coverage Diff              @@
##           maintenance    #2917   +/-   ##
============================================
  Coverage        93.49%   93.49%           
============================================
  Files              104      104           
  Lines            10840    10840           
  Branches          2365     2366    +1     
============================================
  Hits             10135    10135           
  Misses             704      704           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me - checking allProfiles should be more accurate as we can safely remove types that are not present in the profiles array after loading them.

Thanks @t1m0thyj!

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well for me testing with an extender's type, thanks @t1m0thyj for the fix

@JillieBeanSim JillieBeanSim merged commit 02a2e3f into maintenance May 16, 2024
28 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/profiles-race-conditions branch May 16, 2024 17:13
@JillieBeanSim JillieBeanSim modified the milestones: v2.16.0, v2.16.1 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Regression on: fix(ProfilesCache): Clear object caches before refresh #2795
3 participants