-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to open Favorited Job Search #2930
Unable to open Favorited Job Search #2930
Conversation
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SanthoshiBoyina1, thanks for fixing this behavior! Just as a heads up, this is already in place in v3 so no need to port it over 👍
Will approve after a changelog entry is added and tests are addressed 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SanthoshiBoyina1 thanks for tackling this item, I do see a broken unit test suite as well on this PR. Functionality looks good so once mentioned items are address this should be good to go 😄
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Quality Gate failedFailed conditions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2930 +/- ##
==========================================
- Coverage 93.52% 93.50% -0.02%
==========================================
Files 104 104
Lines 10891 10890 -1
Branches 2354 2362 +8
==========================================
- Hits 10186 10183 -3
- Misses 704 706 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SanthoshiBoyina1 LGTM
Hey @traeok and @JillieBeanSim, |
@zFernand0, @traeok mentions in a comment that it is not needed on next branch |
@zFernand0 That line points to the placeholder node that we show when expanding a profile in the Jobs tree w/o a filter, so that should be okay. I've made some adjustments in PR #2827 to address this specific case, so I don't believe this needs to be ported 👍 |
😓 I should've read the whole history of the PR before going through the code. And thanks for clarifying 🙏🏽 |
No worries, thanks for double checking. Better than it slipping through 😄 |
Proposed changes
To add the ability to open a Favorited Job Search under Favorites and as well as when the extension is reloaded.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments