-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick] Add base profile when creating team config #2959
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2959 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 110 110
Lines 10985 10985
Branches 2250 2338 +88
=======================================
Hits 10175 10175
Misses 808 808
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @JillieBeanSim!
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting!
LGTM! 😋
Changes LGTM, thanks @JillieBeanSim! Should be good to merge once conflicts are addressed. |
…tion Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
b76d6f8
Quality Gate passedIssues Measures |
Proposed changes
cherry-picked @t1m0thyj 's work in #2932 to solve a particular issue with base profile not being included in creation of config file
Release Notes
Milestone: 3.0.0-prerelease
Changelog: Fix issue with base profile not being included in fresh team configuration file. #2887
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments