[cherry-pick] Add base profile when creating team config #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2959 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 110 110
Lines 10985 10985
Branches 2250 2338 +88
=======================================
Hits 10175 10175
Misses 808 808
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Jun 14, 2024
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
t1m0thyj
previously approved these changes
Jun 14, 2024
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
t1m0thyj
previously approved these changes
Jun 17, 2024
zFernand0
previously approved these changes
Jun 18, 2024
traeok
previously approved these changes
Jun 18, 2024
|
Changes LGTM, thanks @JillieBeanSim! Should be good to merge once conflicts are addressed. |
…tion Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
JillieBeanSim
dismissed stale reviews from traeok, zFernand0, and t1m0thyj
via
b76d6f8
|
t1m0thyj
approved these changes
Jun 20, 2024
traeok
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
cherry-picked @t1m0thyj 's work in #2932 to solve a particular issue with base profile not being included in creation of config file
Release Notes
Milestone: 3.0.0-prerelease
Changelog: Fix issue with base profile not being included in fresh team configuration file. #2887
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments