fix(v3): Misc. fixes for next branch
#2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Standardized CI workflows to use `pnpm@8` - Streamlined resource URI logic for spool nodes - Removed old JobSpoolProvider (again) and its refs - Fixed behavior for `getProviderForNode` function - Added type guards for USS and Data Set nodes Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2968 +/- ##
==========================================
+ Coverage 92.62% 92.70% +0.07%
==========================================
Files 111 109 -2
Lines 11071 10999 -72
Branches 2394 2357 -37
==========================================
- Hits 10255 10197 -58
+ Misses 814 800 -14
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
requested review from
t1m0thyj,
zFernand0,
JillieBeanSim,
awharn,
rudyflores,
anaxceron,
SanthoshiBoyina1 and
likhithanimma1
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
JillieBeanSim
previously approved these changes
Jun 19, 2024
anaxceron
previously approved these changes
Jun 20, 2024
zFernand0
previously approved these changes
Jun 20, 2024
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
dismissed stale reviews from zFernand0, anaxceron, and JillieBeanSim
via
cb06138
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
reviewed
Jun 25, 2024
zFernand0
approved these changes
Jun 26, 2024
|
t1m0thyj
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pnpm@8getProviderForNodefunction - resolves not being able to add favorites in DS or USS treesIZoweTreeNode.getUSSDocumentFilePathas deprecated as Zowe Explorer no longer uses itRelease Notes
Milestone: vNext
Changelog:
getUSSDocumentFilePathfunction on theIZoweTreeNodeinterface as Zowe Explorer no longer uses the local file system for storing USS files. No replacement is planned; please access data from tree nodes using their resource URIs instead. #2968getProviderForNodereturned the wrong tree provider after a user performed an action on a Zowe tree node. #2967Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executed