-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix sessions disappearing from trees caused by zowe.extRefresh
#3018
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3018 +/- ##
==========================================
+ Coverage 93.47% 93.48% +0.01%
==========================================
Files 104 104
Lines 10978 10982 +4
Branches 2415 2295 -120
==========================================
+ Hits 10262 10267 +5
+ Misses 715 714 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these changes, the sessions persist in the trees and the experience is definitely smoother - LGTM. Thanks @t1m0thyj for looking into these adjustments.
Proposed changes
Ports #3009 from vNext to the main branch
This PR removes some Theia-specific logic in the config watcher. I've tested in Theia that there is no regression for #2211
Release Notes
Milestone: 2.18.0
Changelog: Fixed issue where creating a new team configuration file could cause Zowe Explorer to crash, resulting in all sessions disappearing from trees
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments