-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: Add missing return types, see #2952 #3021
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3021 +/- ##
==========================================
- Coverage 92.87% 92.77% -0.10%
==========================================
Files 107 107
Lines 10913 10897 -16
Branches 2280 2358 +78
==========================================
- Hits 10135 10110 -25
- Misses 776 785 +9
Partials 2 2 ☔ View full report in Codecov by Sentry. |
2bf1197
to
2c454e0
Compare
2c454e0
to
35d25b1
Compare
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
35d25b1
to
2702e39
Compare
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A+
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Fernando! I have a quick request for the encoding
property, but the type changes make sense to me.
…eUSSTreeNode interface Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM - thanks for adding the deprecation comment 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
Proposed changes
Release Notes
Milestone: 3.0
Changelog: Added missing return types to Zowe Explorer API programmatic interfaces.
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments
TODO: