-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: FileSystemProvider remote lookup & change detection #3040
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3040 +/- ##
==========================================
- Coverage 92.94% 92.80% -0.14%
==========================================
Files 112 112
Lines 11261 11386 +125
Branches 2468 2523 +55
==========================================
+ Hits 10466 10567 +101
- Misses 793 817 +24
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…nitializeProviders Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
7aa0a61
to
15b07a7
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…tors in MockedProperty Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
4ff64dc
to
e4ec266
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
21a60e9
to
f817f1e
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @traeok this works great.
just need tests fixed, got excited with functionality :)
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @traeok! Left a few comments
- Added deprecation note about `MemberEntry` - Set `isMember` default value to `false` for `DsEntry` Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
7e2b07c
to
eb510e5
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with virtual zowe-ds
& zowe-uss
workspaces and LGTM, thanks @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Left small comments, but nothing that should prevent this PR from being merged 😋
Nicely done! 🥳
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the coverage @traeok!
Proposed changes
stat
inUssFSProvider
stat
inDatasetFSProvider
BaseProvider
for convenienceRelease Notes
Milestone: vNext
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment