Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: FileSystemProvider remote lookup & change detection #3040

Merged
merged 35 commits into from
Aug 20, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Aug 7, 2024

Proposed changes

  • Support virtual workspaces for the FileSystemProviders (Data Sets and USS files)
  • Remote lookup for FileSystemProvider entries (Data Sets and USS files)
  • Change detection between workspaces
    • Refactored implementation for stat in UssFSProvider
    • Refactored implementation for stat in DatasetFSProvider
  • Make lookup a public function in BaseProvider for convenience

Release Notes

Milestone: vNext

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

traeok added 8 commits July 31, 2024 13:49
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok added 3 commits August 7, 2024 14:57
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok marked this pull request as ready for review August 7, 2024 19:43
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 26 lines in your changes missing coverage. Please review.

Project coverage is 92.80%. Comparing base (7ff0298) to head (5a47fe4).
Report is 36 commits behind head on next.

Files Patch % Lines
...kages/zowe-explorer/src/trees/uss/UssFSProvider.ts 79.41% 14 Missing ⚠️
...we-explorer/src/trees/dataset/DatasetFSProvider.ts 93.22% 8 Missing ⚠️
packages/zowe-explorer-api/src/fs/BaseProvider.ts 94.44% 1 Missing ⚠️
...owe-explorer-api/src/vscode/ZoweVsCodeExtension.ts 75.00% 1 Missing ⚠️
...kages/zowe-explorer/src/trees/shared/SharedInit.ts 88.88% 1 Missing ⚠️
packages/zowe-explorer/src/utils/ProfilesUtils.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3040      +/-   ##
==========================================
- Coverage   92.94%   92.80%   -0.14%     
==========================================
  Files         112      112              
  Lines       11261    11386     +125     
  Branches     2468     2523      +55     
==========================================
+ Hits        10466    10567     +101     
- Misses        793      817      +24     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

traeok added 2 commits August 7, 2024 15:52
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…nitializeProviders

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok force-pushed the refactor/fsp-improvements branch from 7aa0a61 to 15b07a7 Compare August 7, 2024 21:20
traeok added 2 commits August 7, 2024 18:02
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…tors in MockedProperty

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok added 2 commits August 7, 2024 19:36
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok linked an issue Aug 8, 2024 that may be closed by this pull request
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok force-pushed the refactor/fsp-improvements branch from 4ff64dc to e4ec266 Compare August 8, 2024 18:29
traeok added 4 commits August 8, 2024 15:34
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok force-pushed the refactor/fsp-improvements branch from 21a60e9 to f817f1e Compare August 9, 2024 14:25
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
JillieBeanSim
JillieBeanSim previously approved these changes Aug 13, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traeok this works great.

@JillieBeanSim JillieBeanSim self-requested a review August 13, 2024 14:02
@JillieBeanSim JillieBeanSim dismissed their stale review August 13, 2024 14:03

just need tests fixed, got excited with functionality :)

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks @traeok! Left a few comments

packages/zowe-explorer-api/src/fs/types/datasets.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/configuration/SettingsConfig.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/extension.ts Show resolved Hide resolved
- Added deprecation note about `MemberEntry`
- Set `isMember` default value to `false` for `DsEntry`

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok force-pushed the refactor/fsp-improvements branch from 7e2b07c to eb510e5 Compare August 14, 2024 15:39
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok requested a review from t1m0thyj August 14, 2024 15:42
traeok and others added 2 commits August 14, 2024 13:20
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
t1m0thyj
t1m0thyj previously approved these changes Aug 15, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with virtual zowe-ds & zowe-uss workspaces and LGTM, thanks @traeok!

zFernand0
zFernand0 previously approved these changes Aug 20, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Left small comments, but nothing that should prevent this PR from being merged 😋

Nicely done! 🥳

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok dismissed stale reviews from zFernand0 and t1m0thyj via 1130366 August 20, 2024 15:12
@t1m0thyj t1m0thyj requested review from t1m0thyj and zFernand0 August 20, 2024 15:14
t1m0thyj
t1m0thyj previously approved these changes Aug 20, 2024
Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the coverage @traeok!

@traeok traeok merged commit a47a313 into next Aug 20, 2024
19 of 20 checks passed
@traeok traeok deleted the refactor/fsp-improvements branch August 20, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
4 participants