Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI dependency in ZE API #3044

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Update CLI dependency in ZE API #3044

merged 2 commits into from
Aug 13, 2024

Conversation

t1m0thyj
Copy link
Member

Proposed changes

Update CLI dependency in ZE API to fix zowe/zowe-cli#2219

Release Notes

Milestone: 2.18.0

Changelog: Updated the @zowe/cli dependency to fix error when using session with auth type "none"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (c6632cf) to head (a03e682).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3044   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files         104      104           
  Lines       10985    10985           
  Branches     2412     2414    +2     
=======================================
  Hits        10268    10268           
  Misses        716      716           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JillieBeanSim
JillieBeanSim previously approved these changes Aug 13, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @t1m0thyj

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Aug 13, 2024
Copy link

@t1m0thyj
Copy link
Member Author

Updated CLI and other dependencies to use a semver range with a caret (^). This should make the ZE API package easier to maintain since we don't have to bump the version number every time there is a bug fix or security patch made to one of its dependencies such as the CLI package 🙂

@t1m0thyj t1m0thyj requested a review from JillieBeanSim August 13, 2024 18:14
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - thanks Timothy for updating the CLI & refining the version constraints 😋

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @t1m0thyj

@JillieBeanSim JillieBeanSim merged commit 1443cb2 into main Aug 13, 2024
29 of 30 checks passed
@JillieBeanSim JillieBeanSim deleted the chore/update-cli-dep branch August 13, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

RestClient.buildOptions doesn't support session with AUTH_TYPE_NONE
3 participants