Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): Fix codicons in Theia and improve error handling #3056

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Aug 20, 2024

Proposed changes

Fixes #3053

Release Notes

Milestone: 2.18.0

Changelog: N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (ea0b0b0) to head (fd7a3f6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
+ Coverage   93.34%   93.39%   +0.04%     
==========================================
  Files         105      105              
  Lines       11043    11045       +2     
  Branches     2301     2402     +101     
==========================================
+ Hits        10308    10315       +7     
+ Misses        734      729       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj added this to the v2.18.0 milestone Aug 20, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 20, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@t1m0thyj t1m0thyj marked this pull request as ready for review August 21, 2024 11:52
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was so quick! thanks @t1m0thyj

@zFernand0 zFernand0 merged commit 2de66d0 into main Aug 21, 2024
22 of 23 checks passed
@zFernand0 zFernand0 deleted the fix/theia-console-panel branch August 21, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/L
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Theia test failure on v2 branch
3 participants