Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): onProfilesUpdate does not always fire for extenders #3082

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Aug 29, 2024

Proposed changes

Fixes an issue where the event callback for the Team Config file watcher stopped abruptly before firing the emitter for extenders.

Release Notes

Milestone: 2.18.0

Changelog:

  • Resolved an issue where extender event callbacks were not always fired when the team configuration file was created, updated or changed. #3078

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here): next

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok changed the title Fix/v2/config watcher fix(v2): onProfilesUpdate does not always fire for extenders Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.32%. Comparing base (dbf9a74) to head (c1bddf0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3082   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files         105      105           
  Lines       11076    11076           
  Branches     2403     2423   +20     
=======================================
  Hits        10337    10337           
  Misses        738      738           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review August 30, 2024 13:58
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

sonarcloud bot commented Aug 30, 2024

@t1m0thyj t1m0thyj mentioned this pull request Aug 30, 2024
2 tasks
@adam-wolfe adam-wolfe added this to the v2.18.0 milestone Sep 3, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed guarantees that the callback will fire as soon as possible, at least within the same thread of execution.
LGTM 😋

@zFernand0 zFernand0 merged commit db3e26b into main Sep 3, 2024
20 checks passed
@zFernand0 zFernand0 deleted the fix/v2/config-watcher branch September 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants