fix: resolve error when changing token to basic auth

[traeok]

Proposed changes

Fixes #3142

Release Notes

Milestone: 3.0.0 GA (or 3.1 if needed)

Changelog:

• Fixed issue where switching from token-based authentication to user/password would cause an error for nested profiles. #3142

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (838f34d) to head (6108792).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   92.80%   92.79%   -0.01%     
==========================================
  Files         113      113              
  Lines       11669    11663       -6     
  Branches     2457     2564     +107     
==========================================
- Hits        10829    10823       -6     
  Misses        838      838              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 10/9/2024

[traeok]

Quality Gate failed

Failed conditions 69.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

I'm starting to wonder if we should make SonarCloud exclude duplication metrics for test files... I know there are benefits to condensing tests and using shared code, but to another developer it could make revising those tests more difficult. From the CLI side of things, I believe we would prefer code duplication over tests that are difficult to maintain.

[zFernand0]

thanks for handling possible undefined values for jsonLoc as well as reducing code duplication 🙏
LGTM! 😋

[sonarqubecloud]

Quality Gate failed

Failed conditions
65.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[JillieBeanSim]

I still get the issue seen when I created bug but did come from extender, looking into an extender fix.

I am unable to test the API ML scenario with our API ML instance down atm, merging with the 2 approvals.

BTW: sample checks failing due to use of ^ fix is in release PR