Fix 401 error when opening PDS members after cred change

[t1m0thyj]

Proposed changes

ZE:

• Fixed an issue where a 401 error could occur when opening PDS members after updating credentials. #3150
  • Also fixes issue where invalid credentials trigger double "Update Credentials" prompt in new session
  • Also fixes issue where expanding job node to show spool doesn't trigger "Update Credentials" prompt

ZE API:

• Updated the ZoweTreeNode.setProfileToChoice function so that it propagates profile changes to its child nodes. #3150

Release Notes

Milestone: v3 GA (or v3.1 if needed)

Changelog: See Proposed changes

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

Attention: Patch coverage is 94.31280% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (e53dad0) to head (6809327).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/zowe-explorer/src/trees/job/JobTree.ts	91.89%	3 Missing ⚠️
...ackages/zowe-explorer/src/trees/uss/ZoweUSSNode.ts	86.36%	2 Missing and 1 partial ⚠️
...ges/zowe-explorer/src/trees/dataset/DatasetTree.ts	88.88%	2 Missing ⚠️
...ckages/zowe-explorer/src/configuration/Profiles.ts	80.00%	1 Missing ⚠️
...zowe-explorer/src/trees/dataset/ZoweDatasetNode.ts	97.14%	1 Missing ⚠️
...kages/zowe-explorer/src/trees/shared/SharedInit.ts	95.65%	1 Missing ⚠️
packages/zowe-explorer/src/utils/AuthUtils.ts	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3157      +/-   ##
==========================================
+ Coverage   92.81%   92.97%   +0.16%     
==========================================
  Files         113      113              
  Lines       11661    11661              
  Branches     2500     2502       +2     
==========================================
+ Hits        10823    10842      +19     
+ Misses        836      817      -19     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 10/15/2024

[zFernand0]

LGTM! 😋

[zFernand0]

If other applications are running into this problem, they could use this technique as an example.
At least until the enhancement below is implemented:

• Enhance Event Emitter to ignore events generated by same process ID  zowe-cli#2279

Thanks @t1m0thyj 🥳

[JillieBeanSim]

when testing update credentials I got pop errors and still see the issue with 401 in text editor

[sonarcloud]

Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[zFernand0]

LGTM! 😋
left some small comments, but nothing urgent 😅

[zFernand0]

should we deprecate getChildren() of do we still need an async approach to get them? 😋

Same for USS

[t1m0thyj]

I believe we still need an async approach to fetch items from the mainframe when we want to update the tree 😋

[JillieBeanSim]

I am now getting stuck in a loop not able to update credentials when 401 detected, seeing the same with zosmf profiles.

Screen.Recording.2024-10-07.at.4.43.28.PM.mov

search was inplace, I made credentials invalid with right-click update creds options and see this when going to expand data set. expected to be prompted for valid creds but wasn't.

[t1m0thyj]

Thanks @JillieBeanSim and @traeok for testing this PR! I believe both issues should be fixed now - the Update Credentials loop and children not refreshing.

[JillieBeanSim]

Thanks for fixing previous issue with the prompt but I'm sorry to say that I am back to the original issue of the error in the text file 😢

Screen.Recording.2024-10-08.at.9.50.00.AM.mov

[t1m0thyj]

Thanks for fixing previous issue with the prompt but I'm sorry to say that I am back to the original issue of the error in the text file 😢

This behavior happens in V3 because opening files in the editor is handled by the FileSystemProvider, so we'll have to add some logic to the FSP to handle 401 errors if we want it show pop ups instead. I've created a separate issue to track this: #3197

Since this PR fixes the original issue #3150 where credentials failed to update on member nodes, I'd like to get it included with v3.0.1 if possible 😋

[JillieBeanSim]

thanks @t1m0thyj for the fix

[zFernand0]

LGTM! 😋
Thanks for addressing the feedback 😅