Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonar scan properties and remove old system test files #3194

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 7, 2024

Proposed changes

Adds a .sonarcloud.properties file that defines sonar.cpd.exclusions so that hopefully SonarCloud will stop detecting duplication in our test code:
image

Release Notes

Milestone: N/A

Changelog: N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (64481f9) to head (dc8e054).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3194   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files         113      113           
  Lines       11672    11672           
  Branches     2597     2605    +8     
=======================================
  Hits        10833    10833           
  Misses        837      837           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
96.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj marked this pull request as ready for review October 7, 2024 19:30
Copy link

github-actions bot commented Oct 7, 2024

📅 Suggested merge-by date: 10/21/2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clean-up! 🥳

Curious if this PR will fix the reports on GH... 😋
image

LGTM! 🥳

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the Sonar properties Timothy 😋 LGTM

@t1m0thyj t1m0thyj merged commit 60dec5a into main Oct 7, 2024
25 checks passed
@t1m0thyj t1m0thyj deleted the fix/sonar-scan-config branch October 7, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/L
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants