Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix failure w/ Node version during deployment #3226

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 11, 2024

Proposed changes

Update Node versions for lint and deployment workflows

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@traeok traeok added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 11, 2024
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (950524f) to head (1303c87).
Report is 3 commits behind head on release/3.0.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/3.0    #3226   +/-   ##
============================================
  Coverage        92.97%   92.97%           
============================================
  Files              113      113           
  Lines            11661    11661           
  Branches          2604     2617   +13     
============================================
  Hits             10842    10842           
  Misses             817      817           
  Partials             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

@JillieBeanSim JillieBeanSim merged commit 23c8563 into release/3.0 Oct 11, 2024
24 checks passed
@JillieBeanSim JillieBeanSim deleted the ci/deployment-fix branch October 11, 2024 13:35
Copy link

Release failed for the release/3.0 branch. 😢

Error: The process '/usr/bin/git' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/git.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/git.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/git.js:863:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Copy link

Release succeeded for the release/3.0 branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update released size/XS
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants