Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate build:nlsExtract from package.json for webview localization #3263

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

likhithanimma1
Copy link
Contributor

Proposed changes

This PR mainly deals with the optional comments left in PR: #3162

  1. Remove build:nlsExtract from package.json as we already have generateLocalization
  2. Removed localization for one of internal error message.

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
@likhithanimma1 likhithanimma1 added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 18, 2024
Copy link

📅 Suggested merge-by date: 11/1/2024

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (b6218f6) to head (c44d4c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3263    +/-   ##
========================================
  Coverage   93.02%   93.02%            
========================================
  Files         113      113            
  Lines       11720    11720            
  Branches     2527     2639   +112     
========================================
  Hits        10903    10903            
  Misses        815      815            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @likhithanimma1!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Likhitha!

@traeok traeok merged commit d6ddf68 into main Oct 21, 2024
25 checks passed
@traeok traeok deleted the followup/3162 branch October 21, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/S
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants