fix(3.0.3): Prompt in editor for 401 error, fix profile propagation

[traeok]

Proposed changes

Port of #3302 for the 3.0.3 release.

Fixes #3197, #3289

How to test

• Checkout this branch in the repo with VS Code opened
• pnpm install && pnpm build
• After the build has finished, click on the Run & Debug panel on the VS Code Side Bar
• Select "Run VS Code Extension" from the tasks list at the top and select the Play ▶ button
• Once opened, make sure that you have (or set) valid credentials on a profile in ZE
• Execute a search on that profile and expand a folder so that a file/PDS member/spool item is visible
• Before opening the file, right click on your profile -> "Manage Profile" -> "Update Credentials"
• Enter in invalid credentials. I recommend using a fake username to prevent lockouts
• Once finished, try to open the file. Notice the error in the editor appears but you are prompted to update your credentials.
• Enter in the valid credentials
• Once done, click "Try again" in the editor to fetch & open the file

Release Notes

Milestone: 3.0.3

Changelog:

• Fixed issue where users were not prompted to enter credentials if a 401 error was encountered when opening files, data sets or spools in the editor. #3197
• Fixed issue where profile credential updates or token changes were not reflected within the filesystem. #3289

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.04%. Comparing base (98a4d51) to head (4934d65).
Report is 1 commits behind head on port-fixes-4303.

Files with missing lines	Patch %	Lines
packages/zowe-explorer/src/utils/AuthUtils.ts	90.62%	3 Missing ⚠️
...we-explorer/src/trees/dataset/DatasetFSProvider.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           port-fixes-4303    #3318      +/-   ##
===================================================
+ Coverage            93.03%   93.04%   +0.01%     
===================================================
  Files                  113      113              
  Lines                11789    11809      +20     
  Branches              2522     2680     +158     
===================================================
+ Hits                 10968    10988      +20     
  Misses                 819      819              
  Partials                 2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 11/28/2024

[JillieBeanSim]

Hey @traeok thanks for porting these changes. I do see some issues in this branch. In MVS I don't get the pop up and in USS the file is holding outdated info with old credentials. Using same testing scenario shared in original PR

[zFernand0]

I'm not opposed to adding these as part of the 3.0.3 fixes, but I'd like to be respectful for those who've already completed their testing on the 3.0.3 PR 😋

In either case, I'm happy with these changes!

Thanks for porting! 😋

---

I'm seeing some files needed to be changed by prettier and pnpm --filter vscode-extension-for-zowe vscode:prepublish

modified:   packages/zowe-explorer/__tests__/__unit__/utils/AuthUtils.unit.test.ts
modified:   packages/zowe-explorer/l10n/bundle.l10n.json
modified:   packages/zowe-explorer/l10n/poeditor.json

---

Hey @traeok thanks for porting these changes. I do see some issues in this branch. In MVS I don't get the pop up and in USS the file is holding outdated info with old credentials. Using same testing scenario shared in original PR

And yeah, I'm also seeing this on MVS (though I didn't in the original PR 😢

Will re-test Billie's scenario. 😋

[zFernand0]

TL;DR: LGTM! 😋

Apologies for going back and forth on having the promptForAuthError in the stat v. the readFile methods.

In MVS I don't get the pop up and in USS the file is holding outdated info with old credentials. Using same testing scenario shared in original PR

As it stand, these changes make the behavior more consistent since I only see the above behavior in somewhat of an edge case. This scenario may have uncovered a long-standing issue that we've had for quite some time and it's just becoming more visible since Zowe Explorer is more reactive thanks to the file system provider implementation.

Here are some steps to reproduce the problem of not getting a pop-up on the MVS tree. These same steps can be used to reproduce the issue in USS.

1. Open a PDS member (and keep the PDS expanded)
2. Update credentials (via right-click menu) to a dummy/bad user
3. Open another member in the same PDS (notice the pop-up) and DO NOT update your creds
4. Open the same member from step one (notice no pop-up)

Long story short, there may be other areas for improvement related to 401 handling. However, I do believe this PR is an overall improvement on what we have out in the field today 😋

[JillieBeanSim]

thanks @traeok this is working great now ❤️