fix(v2): Update migrated and recalled data sets in tree

[traeok]

Proposed changes

Fixes the following issues:

• Fixed an issue where a migrated data set is unusable after it is recalled through Zowe Explorer
• Fixed an issue where a recalled PDS is expandable after it is migrated through Zowe Explorer
• Fixed an issue where data set nodes did not update if migrated or recalled outside of Zowe Explorer

Release Notes

Milestone: 2.18.1

Changelog:

• Fixed an issue where a migrated data set is unusable after it is recalled through Zowe Explorer. #3294
• Fixed an issue where a recalled PDS is expandable after it is migrated through Zowe Explorer. #3294
• Fixed an issue where data set nodes did not update if migrated or recalled outside of Zowe Explorer. #3294

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here): main (WIP)

[traeok]

"1 New Issue" is an existing problem with ZoweDatasetNode complexity. This should be resolved separately.

[codecov]

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.39%. Comparing base (ed4f867) to head (f278fac).

Files with missing lines	Patch %	Lines
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts	96.55%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           v2-lts    #3333      +/-   ##
==========================================
+ Coverage   93.38%   93.39%   +0.01%     
==========================================
  Files         105      105              
  Lines       11117    11134      +17     
  Branches     2457     2344     -113     
==========================================
+ Hits        10382    10399      +17     
  Misses        734      734              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

📅 Suggested merge-by date: 12/4/2024

[zFernand0]

Had a chance to test this and it seems to work well.

All things considered, LGTM! 😋

---

From an internal conversation 😋

The migration request is sent and the icon changes automatically (which could technically be wrong 😅)
If I do the same dataset search, I still see it there (not-migrated)
But that's just because of how migration/archival schedulers may be configured.

[traeok]

Had a chance to test this and it seems to work well.

All things considered, LGTM! 😋

From an internal conversation 😋

The migration request is sent and the icon changes automatically (which could technically be wrong 😅) If I do the same dataset search, I still see it there (not-migrated) But that's just because of how migration/archival schedulers may be configured.

Thanks for testing Fernando and sorry for quickly dismissing your review 😅 I've addressed the behavior you mentioned where the icon changes right away. Now, we won't change the icon and we'll wait for it to be reflected when listing data sets.

[zFernand0]

Should we update the version of imperative/cli to get the updated cross-spawn 😋

LGTM! 😋

[traeok]

Should we update the version of imperative/cli to get the updated cross-spawn 😋

LGTM! 😋

Once zowe-cli#2374 is merged, I'll bump the SDK/imperative versions in this PR 😁

[zFernand0]

LGTM! 😋

[zFernand0]

Should we update the version of imperative/cli to get the updated cross-spawn 😋
LGTM! 😋

Once zowe-cli#2374 is merged, I'll bump the SDK/imperative versions in this PR 😁

probably have to wait for the new cli version to be on public npm (tomorrow 🙏 )

[zFernand0]

LGTM! 😋
will re-approve once the CLI package is updated 🙏