Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Theia Docker build for Node 20 #7

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 15, 2023

Fixes the Theia Docker build workflow, it ran successfully on the latest commit 🎉

Republished all tags (1.34, 1.37, 1.40) since we discovered that Theia version was not being set correctly.
Thanks to @awharn for helping to debug this issue 🙂

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj marked this pull request as ready for review November 16, 2023 19:11
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
I see the double yarn command went away in favor of a global install and pure-lockfile 😋

@t1m0thyj
Copy link
Member Author

LGTM! 😋 I see the double yarn command went away in favor of a global install and pure-lockfile 😋

I have no idea why installing node-gyp globally helps, but found the suggestion here and it worked 😋

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj

@t1m0thyj t1m0thyj merged commit dd20d36 into main Nov 16, 2023
4 of 5 checks passed
@t1m0thyj t1m0thyj deleted the fix/theia-docker-build branch November 16, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants