forked from facebook/react
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request facebook#5590 from jimfb/use-devtool-for-unknown-p…
…roperty-warning Use devtool for unknown property warning
- Loading branch information
Showing
6 changed files
with
202 additions
and
95 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /** | ||
| * Copyright 2013-2015, Facebook, Inc. | ||
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| * @providesModule ReactDOMDebugTool | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| var ReactDOMUnknownPropertyDevtool = require('ReactDOMUnknownPropertyDevtool'); | ||
|
|
||
| var warning = require('warning'); | ||
|
|
||
| var eventHandlers = []; | ||
| var handlerDoesThrowForEvent = {}; | ||
|
|
||
| function emitEvent(handlerFunctionName, arg1, arg2, arg3, arg4, arg5) { | ||
| if (__DEV__) { | ||
| eventHandlers.forEach(function(handler) { | ||
| try { | ||
| if (handler[handlerFunctionName]) { | ||
| handler[handlerFunctionName](arg1, arg2, arg3, arg4, arg5); | ||
| } | ||
| } catch (e) { | ||
| warning( | ||
| !handlerDoesThrowForEvent[handlerFunctionName], | ||
| 'exception thrown by devtool while handling %s: %s', | ||
| handlerFunctionName, | ||
| e.message | ||
| ); | ||
| handlerDoesThrowForEvent[handlerFunctionName] = true; | ||
| } | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| var ReactDOMDebugTool = { | ||
| addDevtool(devtool) { | ||
| eventHandlers.push(devtool); | ||
| }, | ||
| removeDevtool(devtool) { | ||
| for (var i = 0; i < eventHandlers.length; i++) { | ||
| if (eventHandlers[i] === devtool) { | ||
| eventHandlers.splice(i, 1); | ||
| i--; | ||
| } | ||
| } | ||
| }, | ||
| onCreateMarkupForProperty(name, value) { | ||
| emitEvent('onCreateMarkupForProperty', name, value); | ||
| }, | ||
| onSetValueForProperty(node, name, value) { | ||
| emitEvent('onSetValueForProperty', node, name, value); | ||
| }, | ||
| onDeleteValueForProperty(node, name) { | ||
| emitEvent('onDeleteValueForProperty', node, name); | ||
| }, | ||
| }; | ||
|
|
||
| ReactDOMDebugTool.addDevtool(ReactDOMUnknownPropertyDevtool); | ||
|
|
||
| module.exports = ReactDOMDebugTool; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * Copyright 2013-2015, Facebook, Inc. | ||
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| * @providesModule ReactDOMInstrumentation | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| var ReactDOMDebugTool = require('ReactDOMDebugTool'); | ||
|
|
||
| module.exports = {debugTool: ReactDOMDebugTool}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
src/renderers/dom/shared/devtools/ReactDOMUnknownPropertyDevtool.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /** | ||
| * Copyright 2013-2015, Facebook, Inc. | ||
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| * @providesModule ReactDOMUnknownPropertyDevtool | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| var DOMProperty = require('DOMProperty'); | ||
| var EventPluginRegistry = require('EventPluginRegistry'); | ||
|
|
||
| var warning = require('warning'); | ||
|
|
||
| if (__DEV__) { | ||
| var reactProps = { | ||
| children: true, | ||
| dangerouslySetInnerHTML: true, | ||
| key: true, | ||
| ref: true, | ||
| }; | ||
| var warnedProperties = {}; | ||
|
|
||
| var warnUnknownProperty = function(name) { | ||
| if (DOMProperty.properties.hasOwnProperty(name) || DOMProperty.isCustomAttribute(name)) { | ||
| return; | ||
| } | ||
| if (reactProps.hasOwnProperty(name) && reactProps[name] || | ||
| warnedProperties.hasOwnProperty(name) && warnedProperties[name]) { | ||
| return; | ||
| } | ||
|
|
||
| warnedProperties[name] = true; | ||
| var lowerCasedName = name.toLowerCase(); | ||
|
|
||
| // data-* attributes should be lowercase; suggest the lowercase version | ||
| var standardName = ( | ||
| DOMProperty.isCustomAttribute(lowerCasedName) ? | ||
| lowerCasedName : | ||
| DOMProperty.getPossibleStandardName.hasOwnProperty(lowerCasedName) ? | ||
| DOMProperty.getPossibleStandardName[lowerCasedName] : | ||
| null | ||
| ); | ||
|
|
||
| // For now, only warn when we have a suggested correction. This prevents | ||
| // logging too much when using transferPropsTo. | ||
| warning( | ||
| standardName == null, | ||
| 'Unknown DOM property %s. Did you mean %s?', | ||
| name, | ||
| standardName | ||
| ); | ||
|
|
||
| var registrationName = ( | ||
| EventPluginRegistry.possibleRegistrationNames.hasOwnProperty( | ||
| lowerCasedName | ||
| ) ? | ||
| EventPluginRegistry.possibleRegistrationNames[lowerCasedName] : | ||
| null | ||
| ); | ||
|
|
||
| warning( | ||
| registrationName == null, | ||
| 'Unknown event handler property %s. Did you mean `%s`?', | ||
| name, | ||
| registrationName | ||
| ); | ||
| }; | ||
| } | ||
|
|
||
| var ReactDOMUnknownPropertyDevtool = { | ||
| onCreateMarkupForProperty(name, value) { | ||
| warnUnknownProperty(name); | ||
| }, | ||
| onSetValueForProperty(node, name, value) { | ||
| warnUnknownProperty(name); | ||
| }, | ||
| onDeleteValueForProperty(node, name) { | ||
| warnUnknownProperty(name); | ||
| }, | ||
| } | ||
|
|
||
| module.exports = ReactDOMUnknownPropertyDevtool; |