Handle TF drift more gracefully for ti_resource_group and ti_resource_group_assignment
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherchen
commented
Jul 21, 2024
| @@ -188,7 +191,7 @@ func DeleteResourceGroup(ctx context.Context, d *schema.ResourceData, meta inter | |||
| if err != nil { | |||
| return diag.FromErr(err) | |||
| } | |||
| // TODO: check for users assigned as safety? and assert zero? | |||
There was a problem hiding this comment.
This already happens at the TiDB layer - it doesn't let you delete a resource group if it is still assigned to a user.
otherchen
commented
Jul 21, 2024
| d.Set("user", user) | ||
| d.Set("resourceGroup", resourceGroup) | ||
| d.Set("resource_group", resourceGroup) |
There was a problem hiding this comment.
This was resulting in weird tf diffs - fixing so that we see the correct rg state!
zph
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This article provides a good initial explanation of the expected behaviors of the different CRUD methods for a resource.
In it, it mentions that the
Readmethod should be able to gracefully handle when the resource no longer exists (probably due to manual deletion).I also fixed a bug where
resourceGroupwas supposed to beresource_groupand also modifiedpetoju-->zphin certain places. This makes error logs a bit more clear.