Incorrect position of hit in gseaplot2 like #222

[136s]

Setup

I am reporting a problem with GSEApy version, Python version, and operating
system as follows:

import sys; print(sys.version)
import platform; print(platform.python_implementation()); print(platform.platform())
import gseapy; print(gseapy.__version__)

3.11.0 | packaged by conda-forge | (main, Oct 25 2022, 06:12:32) [MSC v.1929 64 bit (AMD64)]
CPython
Windows-10-10.0.19045-SP0
1.1.1

Expected behaviour

In gseaplot2, the vline of hits should exist at the x coordinate where the line of RES is increasing.

Actual behaviour

The x-coordinates of the increasing RES line do not correspond to the x-coordinates of the vline.
In the following code, hits are the following arrays, for example, but the rightmost orange and blue hit is at the same position (100).

[[3, 5, 6, 8, 14, 16, 18, 21, 23, 36, 47, 60, 66, 69, 77, 94],
 [2, 7, 9, 11, 12, 19, 20, 26, 30, 33, 37, 46, 50, 63, 70, 80, 92]]

Steps to reproduce

import gseapy as gp
import pandas as pd

rnk_url = "https://raw.githubusercontent.com/zqfang/GSEApy/master/tests/data/temp.rnk"
rnk = pd.read_table(rnk_url, header=None, index_col=0)
pre_res = gp.prerank(rnk=rnk.head(100), gene_sets="KEGG_2016", seed=6)

terms = pre_res.res2d.Term[:2]
hits = [pre_res.results[t]["hits"] for t in terms]
runes = [pre_res.results[t]["RES"] for t in terms]
fig = gp.gseaplot2(terms=terms, RESs=runes, hits=hits, ofname="gseaplot2.svg")

[136s]

Hi, I tried to fix this bug. I am not sure if the fix is correct, so please check if you want.

Prior to the fix, pseudo vlines ranged from 0 to the number of terms -1, and when drawing real vlines, they were drawn broadly for each term. Therefore, fix #249 aligns the position of the hit track with the position of the mountain curve increment.
However, I can't figure out why the left edge of the pseudo vlines is off unless it is set to 1 instead of 0.

This is the new output from this fix.

[zqfang]

I think I know what happend here now. but the left edge should be start at 0.

[zqfang]

the left edge should start with 0, to make all hits with x range

[136s]

Sorry, I misunderstood the position of the mountain curve and hit track to be off by 1.
I have confirmed with GSEA 4.3.3 that your correction (the left edge should start with 0) is correct.

[zqfang]

No worries. I should not have make the mistake in the first place