Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve led usage #311

Closed
wants to merge 3 commits into from
Closed

Conversation

optozorax
Copy link

  • Fix usage of macro ML_LED_*
  • Add option to disable default layer indicating on leds

@optozorax
Copy link
Author

Or I think, it is better to move code in DISABLE_DEFAULT_ML_LEDS_LOGIC block into auto-generated code in layer_state_set_user in keymap.c for Oryx. But this is bad from backward compatibility point...

@drashna
Copy link
Collaborator

drashna commented Sep 28, 2020

Thank you for the input!

However, we would like to keep things consistent between the different keyboards (eg, same style of defines, same defaults, etc).

I have a PR upstream to update a number of aspects of the boards. And have included the option to turn off or disable the LED indicators (qmk#10119 if you are interested). And we'd prefer to get that merged upstream first, and then applied to our repo.

@optozorax
Copy link
Author

Thank you! I see MOONLANDER_USER_LEDS in this PR, so I can close this merge request.

@optozorax optozorax closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants