Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Emacs as a unicode input mode #344

Closed
wants to merge 1 commit into from

Conversation

chewxy
Copy link

@chewxy chewxy commented Apr 27, 2022

I added a new unicode input mode: emacs. (see also: PR in the main qmk branch: qmk#16949)

While strictly not an operating system, inserting unicode characters in emacs has its own keybinding. The most usual way is C-x-8 RET followed by the unicode in hex. As a person who works across different OSes but with the constant being emacs, this was the most straightforward way forwards.

Of course, the main credit goes to TrentinQuarantino in this emacs stack exchange post.

Description

I added a new unicode input mode in quantum/process_unicode_common.(c|h). Then I updated all the programmer friendly numbers of the enums, and added documentation too.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Additional notes

I'm unfamiliar with the testing protocols of this project. If I could get some help that'd be great. I'm reasonably familiar with C. However, what I have done is I have flashed two ergodox-EZs with this and tested it on emacs on both linux and macos. My Windows computer isn't quite available right now, so I'm unable to test on Windows.

@drashna
Copy link
Collaborator

drashna commented Jun 2, 2022

Generally, we dont accept PRs directly. They should go through QMK first, and then will get pulled down from there.

@drashna drashna closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants