Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing logrus and adding comments #14

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Conversation

depado
Copy link
Contributor

@depado depado commented Sep 28, 2017

See sirupsen/logrus#451 for details.
It is now recommended to not use the uppercase version of sirupsen/logrus but instead always use the lowercase.
Also, from the README.md of the logrus project :

Seeing weird case-sensitive problems? It's in the past been possible to import Logrus as both upper- and lower-case. Due to the Go package environment, this caused issues in the community and we needed a standard. Some environments experienced problems with the upper-case variant, so the lower-case was decided. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

I also fixed a few comments.

@natefinch
Copy link
Contributor

👍 Apologies for requiring this re-patch. This is the correct import now.

@zsais
Copy link
Owner

zsais commented Oct 1, 2017

Thanks for that catch @depado 👍

@zsais zsais merged commit bdee3a8 into zsais:master Oct 1, 2017
@depado depado deleted the logrus_fix branch October 2, 2017 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants