dimensional height offset -> 1.18.1 #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2023 20:26
conversion scheme still converts Minecraft's a right-handed system to Mumble's left-handed system but using a different approach (switching z axis instead of previously swapping z and y axis) fixes #55
// Make people in other dimensions far away so that they're muted.
val yAxisAdjuster = (world.registryKey.value.stableHash % 2048) * config.clientDimensionYAxisAdjust
camPos[1] += yAxisAdjuster
/**
* A stable hash function designed for world IDs.
* Different clients should be able to run this on the same world ID and get the same result.
*
* Based on the `djb2` hash function: [Hash Functions](http://www.cse.yorku.ca/~oz/hash.html)
*/
val Identifier.stableHash: Int
get() {
var hash = 5381
for (c in this.toString()) {
hash += (hash shl 5) + c.code
}
return hash
}
fixes #35
zsawyer
commented
Jan 24, 2023
Comment on lines
+231
to
+238
| ResourceKey<Level> dimension = game.player.level.dimension(); | ||
| if (dimension == null) { | ||
| // silently ignoring because it would become too spammy | ||
| return; | ||
| } | ||
|
|
||
| int configuredOffset = MumbleLinkImpl.dimensionalHeight(); | ||
| int hash = LinkAPIHelper.stableHash(dimension.toString()); |
There was a problem hiding this comment.
I am not sure if this dimension.toString is the same as what fabrics implementation uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix #35