Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed Policy Reorder Resource to validate Deception Rule #450

Merged
merged 3 commits into from
May 4, 2024
Merged

fix: Fixed Policy Reorder Resource to validate Deception Rule #450

merged 3 commits into from
May 4, 2024

Conversation

willguibr
Copy link
Member

fix: Fixed Policy Reorder Resource to validate Deception Rule

@willguibr willguibr self-assigned this May 3, 2024
@willguibr willguibr added type/bug Something isn't working type/enhancement New feature or request ⚙️ In development ⚙️ Under active development labels May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.62162% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 76.29%. Comparing base (8d75ef3) to head (a4f8f95).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   76.42%   76.29%   -0.14%     
==========================================
  Files          89       89              
  Lines       15695    15752      +57     
==========================================
+ Hits        11995    12018      +23     
- Misses       3000     3027      +27     
- Partials      700      707       +7
Files Coverage Δ
zpa/data_source_zpa_service_edge_group.go 87.07% <100.00%> (+0.51%) ⬆️
zpa/resource_zpa_service_edge_group.go 76.02% <85.71%> (+0.86%) ⬆️
zpa/resource_zpa_policy_access_rule_reorder.go 70.71% <54.76%> (-5.81%) ⬇️

... and 5 files with indirect coverage changes

@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 3, 2024 21:08 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 3, 2024 21:24 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 3, 2024 21:58 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 3, 2024 22:17 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 4, 2024 00:27 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 4, 2024 00:45 — with GitHub Actions Inactive
@willguibr willguibr merged commit fb1a54a into master May 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@willguibr willguibr

Labels
⚙️ In development ⚙️ Under active development type/bug Something isn't working type/enhancement New feature or request
Projects
Zscaler Automation Dashboard 🛣
Status: 🚀 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willguibr @codecov-commenter