Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed Application Segment Port Configuration Resource #496

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Oct 4, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr self-assigned this Oct 4, 2024
@willguibr willguibr added the type/bug Something isn't working label Oct 4, 2024
@willguibr willguibr added this to the Release v3.33.7 milestone Oct 4, 2024
@willguibr willguibr linked an issue Oct 4, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 74.95770% with 148 lines in your changes missing coverage. Please review.

Project coverage is 75.86%. Comparing base (7210f29) to head (70d7cba).

Files with missing lines Patch % Lines
zpa/data_source_zpa_app_connector_controller.go 80.75% 46 Missing ⚠️
zpa/common.go 73.63% 16 Missing and 13 partials ⚠️
zpa/resource_zpa_application_segment_inspection.go 58.33% 7 Missing and 3 partials ⚠️
zpa/resource_zpa_segment_group.go 74.35% 6 Missing and 4 partials ⚠️
zpa/resource_zpa_server_group.go 63.15% 6 Missing and 1 partial ⚠️
...a_source_zpa_application_segment_browser_access.go 0.00% 2 Missing and 4 partials ⚠️
.../data_source_zpa_application_segment_inspection.go 0.00% 2 Missing and 4 partials ⚠️
zpa/resource_zpa_application_segment_pra.go 70.00% 4 Missing and 2 partials ⚠️
zpa/data_source_zpa_application_segment.go 58.33% 2 Missing and 3 partials ⚠️
zpa/data_source_zpa_application_segment_pra.go 16.66% 2 Missing and 3 partials ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   75.83%   75.86%   +0.02%     
==========================================
  Files          92       92              
  Lines       17746    17549     -197     
==========================================
- Hits        13458    13313     -145     
+ Misses       3442     3388      -54     
- Partials      846      848       +2     
Files with missing lines Coverage Δ
zpa/resource_zpa_policy_access_redirection_rule.go 71.52% <100.00%> (-3.34%) ⬇️
zpa/resource_zpa_policy_access_rule.go 77.38% <100.00%> (-1.97%) ⬇️
zpa/resource_zpa_policy_access_rule_v2.go 79.22% <100.00%> (+5.50%) ⬆️
zpa/data_source_zpa_app_connector_group.go 85.44% <50.00%> (ø)
zpa/resource_zpa_app_connector_group.go 63.21% <50.00%> (ø)
zpa/data_source_zpa_server_group.go 84.24% <92.68%> (-2.46%) ⬇️
zpa/resource_zpa_application_segment.go 70.81% <63.63%> (+3.59%) ⬆️
...resource_zpa_application_segment_browser_access.go 66.05% <76.47%> (+4.94%) ⬆️
zpa/data_source_zpa_application_segment.go 88.60% <58.33%> (+1.04%) ⬆️
zpa/data_source_zpa_application_segment_pra.go 92.00% <16.66%> (-0.19%) ⬇️
... and 9 more

@willguibr willguibr merged commit 1eb0655 into master Oct 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

TCP Port Ranges getting set as individual ports instead of ranges
2 participants