Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed zpa_application_segment_pra #499

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Oct 30, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 55.69620% with 35 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (1eb0655) to head (a597b5c).

Files with missing lines Patch % Lines
zpa/resource_zpa_application_segment_pra.go 52.05% 29 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   72.04%   70.99%   -1.06%     
==========================================
  Files          92       92              
  Lines       19640    19405     -235     
==========================================
- Hits        14150    13776     -374     
- Misses       4642     4787     +145     
+ Partials      848      842       -6     
Files with missing lines Coverage Δ
zpa/data_source_zpa_app_connector_group.go 84.02% <100.00%> (+0.03%) ⬆️
zpa/resource_zpa_app_connector_group.go 57.21% <ø> (-1.93%) ⬇️
zpa/resource_zpa_application_segment.go 52.03% <100.00%> (-15.19%) ⬇️
...resource_zpa_application_segment_browser_access.go 58.01% <ø> (-4.20%) ⬇️
zpa/resource_zpa_application_segment_inspection.go 80.91% <100.00%> (ø)
zpa/resource_zpa_application_segment_pra.go 51.30% <52.05%> (-23.53%) ⬇️

... and 6 files with indirect coverage changes

@willguibr willguibr self-assigned this Oct 30, 2024
@willguibr willguibr added type/bug Something isn't working ⚙️ In development ⚙️ Under active development labels Oct 30, 2024
@willguibr willguibr merged commit a976d51 into master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ In development ⚙️ Under active development type/bug Something isn't working
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants