Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load prezto functions on plugin load #43

Merged
merged 2 commits into from Feb 22, 2013
Merged

load prezto functions on plugin load #43

merged 2 commits into from Feb 22, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2013

pmodloading the prezto module instead of sourcing init.zsh loads the module's functions, should improve issue #40.

@sharat87
Copy link
Member

The pmodload function is defined by prezto. So, your implementation is fine for those who use prezto, but for those who don't, loading any plugin with a init.zsh will break the whole thing.

So, may be check for the existence of the pmodload function, and act accordingly. That is, if that function is available, we use your implementation, else, we just source it like it is done currently.

Could you make this change, so I'll merge it? Thank you!

@ghost
Copy link
Author

ghost commented Feb 21, 2013

this should work, not sure if there isn't a cleaner way to do it

@sharat87 sharat87 merged commit b84ae11 into zsh-users:master Feb 22, 2013
@sharat87
Copy link
Member

Yes, thanks. Merged :)

@ghost ghost deleted the feature/prezto branch February 22, 2013 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants