Don't bind any zle-* methods #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like all the zle-* methods are special and shouldn't be monkeyed with. Specifically `zle-isearch-update` and friends. Binding that widget caused `history-incremental-pattern-search` to stop working. Fixes zsh-users/zsh-syntax-highlighting#387
docwhat
added a commit
to docwhat/dotfiles
that referenced
this pull request
Nov 5, 2016
Figured out what was causing the problem(s). I reported it at zsh-users/zsh-syntax-highlighting#387 I submitted a pull request at zsh-users/zsh-autosuggestions#206
docwhat
added a commit
to docwhat/dotfiles
that referenced
this pull request
Nov 5, 2016
Figured out what was causing the problem(s). I reported it at zsh-users/zsh-syntax-highlighting#387 I submitted a pull request at zsh-users/zsh-autosuggestions#206
|
I apologize. I meant to target the |
|
I will look more into this PR later, but for now you may be able to get the desired behavior by adding % ZSH_AUTOSUGGEST_IGNORE_WIDGETS=($ZSH_AUTOSUGGEST_IGNORE_WIDGETS zle-\*) |
|
Cherry picked onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like all the zle-* methods are special and shouldn't be
monkeyed with.
Specifically
zle-isearch-updateand friends. Binding that widgetcaused
history-incremental-pattern-searchto stop working.Fixes zsh-users/zsh-syntax-highlighting#387