-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some times misses first character #169
Comments
I presume this doesn't happen under Do you any |
thanks a lot! :) |
It's "ignore (most) user and system dotfiles". See I'm not familiar with oh-my-zsh, but try making |
I'm guessing this is resolved. |
EDIT: forget what i said, the plugin was turned off. I'll get to this issue soon. Can you please re-open? might be worth to mention it in the docs though, it's not obvious for newcomers. |
Reopened. I don't understand what docs change you are proposing? |
@danielshahaf i meant emphasizing that the zsh-syntax-highlighter should be sourced after all other zsh plugins. for example, i'm sourcing this plugin using oh-my-zsh. so i have this in my plugins=(
archlinux systemd
python pip django celery virtualenv virtualenvwrapper
npm
go
aws tugboat
tmux
docker
colored-man colorize web-search
history-substring-search
zsh-syntax-highlighting # syntax-highlighting plugin must be sourced last
) |
@oryband zsh-syntax-highlighting/README.md already says that (in the installation instructions, and reemphasized in the FAQ later in the file). What would you change / add? |
@danielshahaf maybe be more direct. Write:
instead of:
|
@oryband Perhaps this? diff --git a/README.md b/README.md
index cb22c37..c14c9df 100644
--- a/README.md
+++ b/README.md
@@ -39,7 +39,7 @@ How to install
cd ~/.oh-my-zsh/custom/plugins
git clone git://github.com/zsh-users/zsh-syntax-highlighting.git
-* Activate the plugin in `~/.zshrc` (in **last** position):
+* Activate the plugin in `~/.zshrc`:
plugins=( [plugins...] zsh-syntax-highlighting)
@@ -47,6 +47,8 @@ How to install
source ~/.zshrc
+Note that `zsh-syntax-highlighting` must be the last plugin sourced,
+so make it the last element of the `$plugins` array.
FAQ
--- Incidentally, the 'at end of .zshrc' requirement may be removed some day, if/when the redrawhook work is merged. |
@danielshahaf looks good 👍 |
keep this issue open though, i want to debug the missing char problem and haven't got to it yet |
Suggested-by: Ory Band (on issue #169)
Alright. I suspect history-substring-search might have something to do with it; it duplicates some code from zsh-syntax-highlighting.zsh: https://github.com/robbyrussell/oh-my-zsh/blob/aa15ebad3e9c86fbd8dd5f01803066f82ece9593/plugins/history-substring-search/history-substring-search.zsh#L180 |
@danielshahaf can these two plugins coexist together? history-substring-search says to source itself after zsh-syntax-highlighting. They're contradicting each other! |
The documentation of h-s-s says it is compatible with z-sy-h. However, h-s-s relies on undocumented implementation details of z-sy-h (such as the existence of a While you're here, are you in contact with h-s-s's authors? The use of |
@danielshahaf i'm not in touch with them, just an observer. i actually don't know anything about the implementation. maybe ping them upstream? |
It's already fixed upstream: zsh-users/zsh-history-substring-search@c61c995 What about your missing character problems, have you got to the bottom of them yet? |
yup! thanks :) |
Some time when I start typing a command, the first characters is ignored:
This has started since I started using this plugin in two different machines, ubuntu and arch.
The text was updated successfully, but these errors were encountered: