Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting not working when using menu completion #25

Closed
claytron opened this issue Jan 5, 2011 · 12 comments
Closed

Highlighting not working when using menu completion #25

claytron opened this issue Jan 5, 2011 · 12 comments
Labels

Comments

@claytron
Copy link

claytron commented Jan 5, 2011

If you were to tab complete a command, only part of the command ends up being highlighted with the unknown-token syntax.

Example:

% py<TAB>
% python
  |/\   |
  |  `---`---- No highlighting
  `------- The "py" has the "unknown token" highlighting
@nicoulaj
Copy link
Member

nicoulaj commented Jan 5, 2011

It works fine for me, are you sure you sourced the script at the end of you ~/.zshrc, after all your completion stuff ?

@paradoxxxzero
Copy link
Contributor

I've got the same problem, because I use menu style completion :
zstyle ':completion:::*:default' menu yes select
I have in fact this behavior when I browse the menu.
The line buffer changes but as far as I know no hookable function exists to rehighlight the buffer (its not a line editing thing).
When I hit enter or space and leave the menu, highlighting comes back to normal.
Example, hit zs and tab :

@nicoulaj
Copy link
Member

nicoulaj commented Jan 5, 2011

You are right, I'm renaming the issue.

@claytron: this repository contains your up-to-date completion settings, right ?

@claytron
Copy link
Author

claytron commented Jan 5, 2011

Yeah those are my latest dotfiles

@nicoulaj
Copy link
Member

nicoulaj commented Jan 5, 2011

Looks like this was fixed at a765f76.
Can you confirm ?

@paradoxxxzero
Copy link
Contributor

Still not working for me...

@claytron
Copy link
Author

claytron commented Jan 5, 2011

Not working for me either. Now I get an error loading opp.zsh also.

(eval):1: bad pattern: opp-gps-(
(eval):1: parse error near `)'
(eval):1: parse error near `&&'
(eval):1: parse error near `&&'
(eval):1: bad pattern: opp-gps-[
(eval):1: parse error near `}'

I wasn't receiving that error before. Do I still need to move the sourcing of the plugin to the end of the .zshrc?

@paradoxxxzero
Copy link
Contributor

If you source opp.zsh after zsh-syntax-highlighting, do you still get this error ?

@claytron
Copy link
Author

claytron commented Jan 5, 2011

That was the issue. I moved the sourcing of the plugins to the bottom and made opp.zsh go last. Now everything works fine, including the highlighting on completion.

claytron/dotfiles@b4008b4

@nicoulaj
Copy link
Member

nicoulaj commented Jan 5, 2011

Cool, closing this issue.

@paradoxxxzero
Copy link
Contributor

Menu highlighting still doesn't trigger buffer redraw for me when navigating in possible completions

@nicoulaj
Copy link
Member

nicoulaj commented Jan 6, 2011

Damn, we can't reopen issues.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants