No highlighting while cycling menu completion results

[m0vie]

While cycling through results in menu completion, no highlighting is applied:

1. No widget is called for current master branch.

2. zle-line-pre-redraw is not called, either.

Not sure about 1), but 2) can probably be fixed by introducing another redrawhook(); in upstream.

[danielshahaf]

Patch upstream: workers/39590

[danielshahaf]

Committed upstream in zsh-users/zsh@5b192a4. @m0vie, I assume we can close this issue, unless there is a z-sy-h side fix that can be done to support older zsh's?

[danielshahaf]

(To be clear: the upstream patch fixes this issue.)

[m0vie]

Yes, I don't think there is anything we can do to make it work with older versions.

[ratheesh]

I still observe this issue in zsh v.5.3.1. Can somebody confirm if this is fixed in latest zsh.

[danielshahaf]

@ratheesh Yes, it's fixed in latest zsh.

[ratheesh]

If I enable menu select using
zstyle ':completion:*:*:*:*:*' menu select,
the functionality breaks. Is this expected?
Is there a setting or workaround to get this working?

[danielshahaf]

If I enable menu select using `zstyle ':completion:*:*:*:*:*' menu select`, the functionality breaks. Is this expected? Is there a setting or workaround to get this working?

Which version of zsh are you using? 5.3.1 doesn't have the fix; only latest master does. (I can't easily test that `zstyle` right now, but FWIW, my usual setting — which I assume I was testing with — is `zstyle ':completion:*' menu select=long-list select=3`.)

[ratheesh]

@danielshahaf
I am using 5.3.1. But I also tried the latest master(a6135f6) branch. I still see this issue.
I tried zstyle config that you mentioned, I did not see any difference.

[danielshahaf]

Reopening per @ratheesh's last comment. @ALL Can somebody investigate this?

[danielshahaf]

(Sorry for shouting. I typed "all" in lowercase; I think it's a github bug.)

[ratheesh]

@m0vie @danielshahaf
I still observe this issue with zsh v.5.4 that was tagged yesterday and latest zsh-syntax-highlighting module.
I am not sure if I am missing something during testing.

[danielshahaf]

With zsh 5.3.1-test-2-0-gd17f9d32f (similar to 5.4) and autoload compinit; compinit; zstyle :completion:\* menu select and cd /etc/<TAB><TAB><TAB>, the various /etc/foo names being completed are not underlined. However, the trailing slash on dirs is bold.

The fix mentioned about is about zle-line-pre-redraw which is not used by the master branch; it is used by the feature/redrawhook branch, however, the behaviour there is similar to the behaviour on master.

Could somebody please confirm (a) that the above is a valid test case for this issue, (b) that it used to work at one time with some (which?) combination of zsh and z-sy-h?

[m0vie]

This feature only works correctly, if the zle-line-pre-redraw hook is used. It does not work correctly with latest zsh master / z-sy-h master.

About your questions:
(a) Yes, that seems to be a valid test case. The bold trailing slash you are seeing is due to zsh itself (zle_highlight[suffix]).
(b) With zle-line-pre-redraw, this has been working since zsh 5.3.

By the way: I just saw that my comment from June 03 was totally misplaced, that one was about the isearch issue. (I removed it)

[ratheesh]

with zsh 5.4.1 master and z-sy-h feature/redrawhook branch, this feature works fine for me.
I could not test it on zsh 5.3

[ratheesh]

Just to add, z-sy-h feature/redrawhook branch breaks zsh-autosuggestions plugin highlighting.

[ratheesh]

may I know if any got a chance look into this.

[danielshahaf]

Sorry, missed your comments.

with zsh 5.4.1 master and z-sy-h feature/redrawhook branch, this feature works fine for me.

Okay; labeled as such and added to the list in #245. Hopefully redrawhook will be merged for 0.7.0 so this will be fixed then.

Just to add, z-sy-h feature/redrawhook branch breaks zsh-autosuggestions plugin highlighting.

Please test with latest master of both and if it's still a problem, open a new issue. Thanks!

[ColemanGariety]

I'm experiencing this, which has been an issue for nine years, wow (#25)! What's the latest fix?

[danielshahaf]

Will be fixed when redrawhook is fixed, hopefully soon. In the meantime you can workaround this by using (or merging) the feature/redrawhook branch.

[nhooyr]

@danielshahaf Why isn't that branch just merged into master?

I'm seeing this in latest zsh 5.8 from homebrew.

[danielshahaf]

Because it causes a regression in a certain class of use-cases (see #418 and #579) and we're trying to figure out how to solve that regression without making a change to zsh itself (zsh-users/zsh#57), waiting for the next zsh release, and requiring all users to upgrade to that.

[nhooyr]

Awesome, thanks for responding!

[nhooyr]

🎉🎉

Congrats guys!

[danielshahaf]

Thanks :-)