Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zle: don't override *delete* and *kill* #151

Closed
wants to merge 1 commit into from

Conversation

eras
Copy link

@eras eras commented Sep 25, 2014

This restores the ability to consecutively delete (ie.) words and
have them come back consecutively in the next yank.

This restores the ability to consecutively delete (ie.) words and
have them come back consecutively in the next yank.
@danielshahaf
Copy link
Member

This PR is intended to fix #150

@nicoulaj
Copy link
Member

(Closing/reopening to trigger continuous integration)

@vincentbernat
Copy link
Contributor

Another possibility is to restore kill/yank flags for the impacted ZLE widgets.

zle -f kill
zle -f yankbefore
zle -f yank

@danielshahaf
Copy link
Member

@vincentbernat Yeah, that's discussed in #150 (comment) and subsequent comments.

Presently the priority is to merge redrawhook, which should fix these issues as well under zsh 5.9. Related issues include #418, #579, and #735.

The proof-of-concept patch in the linked comment will nevertheless be good to merge, as it will fix this issue under zsh versions that have zle -f but won't use redrawhook. (zle -f was introduced in 5.2; zle-line-pre-redraw in 5.3; and memo= will be introduced in 5.9.) Does that patch introduce any regressions? Off the top of my head, as written it will cause stderr spam on zsh versions too old to have zle -f.

I haven't the brainwidth to pursue this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants