Multiline #159
Merged
Multiline #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function will be used in the next commit.
Given the following input:
PREBUFFER=$'echo "foo\n'
BUFFER='bar"'
This patch causes the '"foo' part to be highlighted as a string. There
is no test because the tests only check highlighting of BUFFER, and 'bar"'
is already highlighted correctly.
|
I've pushed another commit to the branch that handles the before-the-newline part of multiline strings. (I accidentally left that part out during a rebase.) |
|
The fourth patch 384be15 does not fix the case of a literal newline immediately followed by a space. It does fix the case of a literal newline immediately followed by non-whitespace. I presume the whitespace-skipping logic of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'main' highlighter does not highlight certain multiline constructs
correctly. By code inspection, it disregards $PREBUFFER entirely, so any
multiline construct where the start of a line is not a new command would be
misparsed and mishighlighted. This patch series fixes a few such cases.
Regression tests are included.