Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#148] command being typed as neither green nor red #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielshahaf
Copy link
Member

Related to #148: this patch adds a highlight style for the command word, while it is being typed (similar to path_prefix).

The style used is yellow underline, the same style the now-removed path_approx used.

The intention is to avoid the unknown-token style whilst inputting the command. Future changes may fine tune this further (as discussed in #148), for example, only use the new style when the input-so-far is a prefix of a command or function name.

…ommand word.

Adds the 'command-being-input' highlight.

Builds on top of the 'command-word-separator-v1' branch from PR zsh-users#243.
@danielshahaf
Copy link
Member Author

Perhaps this should use $#LBUFFER (= $CURSOR) instead of $#BUFFER.

@nicoulaj nicoulaj closed this Aug 15, 2017
@nicoulaj nicoulaj reopened this Aug 15, 2017
@nicoulaj
Copy link
Member

(Closing/reopening to trigger continuous integration)

@phy1729
Copy link
Member

phy1729 commented Dec 15, 2017

Can this use command_prefix or arg0_prefix to be consistent with other in progress styles?

@vegerot
Copy link

vegerot commented Sep 9, 2019

I still think a command_prefix or arg0_prefix would be very useful to me and others. Is there any progress on allowing this?

@danielshahaf
Copy link
Member Author

Thanks for the ping. Milestoning: small change, but destabilizing, so 0.8.0. (0.7.0 is closed for destabilizing changes.)

@danielshahaf
Copy link
Member Author

Cross-referencing #695.

This is really a sub-issue of #695, so taking this out of the milestone. #695 is still milestoned (not sure whether it'd be fixed before the release, but it's on the shortlist).

@danielshahaf danielshahaf removed this from the 0.8.0 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants