Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/source schedulefields #72

Closed
wants to merge 9 commits into from
Closed

Feature/source schedulefields #72

wants to merge 9 commits into from

Commits on Feb 8, 2021

  1. Refactor out Ordinal

    @koenichiwa
    koenichiwa committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1ad422e View commit details
    Browse the repository at this point in the history

  2. Refactor out Specifier and RootSpecifier

    @koenichiwa
    koenichiwa committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    4df24a8 View commit details
    Browse the repository at this point in the history

  3. Refactor out Queries

    @koenichiwa
    koenichiwa committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1230ae5 View commit details
    Browse the repository at this point in the history

  4. Refactor out parsing 

    Needed to make source field in Schedule public. Need to specify it in Schedule::new, but that means carrying the string through the parser.
    @koenichiwa
    koenichiwa committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c90f101 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Found one leak.

    @koenichiwa
    koenichiwa committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    8861e3e View commit details
    Browse the repository at this point in the history

  2. I'm blind

    @koenichiwa
    koenichiwa committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d87388d View commit details
    Browse the repository at this point in the history

  3. Two non-parsing tests in the parsing module

    @koenichiwa
    koenichiwa committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c9b8237 View commit details
    Browse the repository at this point in the history

  4. Add ScheduleFields, Remove Option from source

    @koenichiwa
    koenichiwa committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    acc8f9d View commit details
    Browse the repository at this point in the history

  5. Expose ScheduleFields

    @koenichiwa
    koenichiwa committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a55141d View commit details
    Browse the repository at this point in the history