Add ScheduleFields, Remove Option from source #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost the same code as #72 but this time I actually synced my fork. I will close that pull request momentarily. Implementation for #71
The only difference between this pull request and #72 is that ScheduleFields is not exposed now.
Changes are pretty simple. ScheduleFields is a struct that holds all the TimeSpec fields previously found in Schedule. Schedule nouw only holds
source: Stringandfields: ScheduleFields. Due to this change, the source is immediately assigned, and doesn't have to be of typeOption<String>anymore.Last change is that in the trait implementation of Schedule, all instances of
self.years(etc.) are changed toself.fields.years(etc.)