Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the Ember NCP key table when reforming the network #700

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

cdjackson
Copy link
Member

Clear all keys from the Ember key table when reforming the network. Without this, APS link keys may remain that will prevent devices from joining the new network when uses the trust centre link key.
Signed-off-by: Chris Jackson chris@cd-jackson.com

@cdjackson cdjackson added the EMBER label Aug 1, 2019
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #700 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #700      +/-   ##
============================================
+ Coverage     27.85%   27.87%   +0.01%     
- Complexity     3532     3534       +2     
============================================
  Files          1365     1365              
  Lines         48986    48994       +8     
  Branches       2114     2114              
============================================
+ Hits          13644    13655      +11     
+ Misses        34718    34715       -3     
  Partials        624      624
Impacted Files Coverage Δ Complexity Δ
...gle/ember/internal/EmberNetworkInitialisation.java 3.33% <0%> (-0.03%) 1 <0> (ø)
...om/zsmartsystems/zigbee/dongle/ember/EmberNcp.java 26.64% <100%> (+1.64%) 13 <1> (+1) ⬆️
...e/ember/ezsp/command/EzspClearKeyTableRequest.java 57.14% <0%> (+57.14%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52251bb...9689b74. Read the comment docs.

Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@cdjackson cdjackson force-pushed the ember_key_table_clear branch from 4166aaa to 9689b74 Compare August 1, 2019 22:53
@cdjackson cdjackson merged commit fea5eae into master Aug 2, 2019
@cdjackson cdjackson deleted the ember_key_table_clear branch August 2, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant