fix: doc typo #198
Open
fix: doc typo #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issues #125
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 30 30
Lines 121 121
Branches 31 31
=====================================
Hits 121 121Continue to review full report at Codecov.
|
fatfisz
requested changes
Jun 1, 2020
| @@ -130,7 +130,7 @@ The official recommendation for running `common-tags` is as follows: | |||
|
|
|||
| - [Node.js](https://nodejs.org/en/download/) v5.0.0 or higher | |||
| - In order to use `common-tags`, your environment will also need to support ES2015 tagged templates ([pssst… check Babel out](http://babeljs.io)) | |||
| - You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `Array.prototype.includes` | |||
| - You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `String.prototype.includes` | |||
There was a problem hiding this comment.
Could you include both? As in
Suggested change
| - You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `String.prototype.includes` | |
| - You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `Array.prototype.includes`, `String.prototype.includes` |
There was a problem hiding this comment.
The string one is used in splitStringTransformer, and the array one is used eg. in trimResultTransformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues #125