-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-6: added new feature: getAttributes #7
Conversation
@ericbroda, thanks for the PR!! 😃 Can you fix the failing test and update the README? The error in Travis CI:
|
@zuazo, I made the changes to the README and managed to fix the majority of test cases, however, there is one remaining error in test cases:
I have spent a few days on this one item and I would like to humbly ask for your assistance in figuring out what I need to do to fix this one remaining test error. I will be happy to fix the remaining errors if you may be able to provide some guidance. (Note: I know the code does actually work as I can run it successfully - it is just the test cases that seem to be causing the issue) |
Merged in master manually. The fix in 4b89b12 and an improvement in 110d0ed. Thanks for all your fantastic work @ericbroda. The PR you made is really hard to do. 😉 |
Released in |
Added feature: "getAttributes" to select multiple attributes in a single call.
Addresses issue #6