Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOLVED issue where the entrypoint could not support object-based en… #274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bsnuggs1
Copy link

@bsnuggs1 bsnuggs1 commented Sep 17, 2020

…vironment variables.

This change allows majority of the SAML environment variables to be configured via the environment parameter in docker.

I created this change to offer an alternative solution to #242

@timabbott
Copy link
Member

@bsnuggs1 can you fix the shellcheck errors flagged by CI?

@bsnuggs1 bsnuggs1 force-pushed the feature/entrypoint-settings-object-type-support branch from 0404e09 to 1071c6b Compare September 18, 2020 04:25
@bsnuggs1
Copy link
Author

Sure thing, I applied the fix just now.

@timabbott
Copy link
Member

Can you show the output of what this generates in a sample case? I'm not convinced that the escaping will actually work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants