Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for .env files #375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added support for .env files #375

wants to merge 2 commits into from

Conversation

mnzaki
Copy link

@mnzaki mnzaki commented Nov 29, 2022

This allows users to simply set values in a .env file and keep using the docker-compose.yml file as-is, so that updates are easier

@maltokyo
Copy link
Contributor

Thanks, this would be great! I have a question on this. I have to comment out the port lines for 80 and 443, as my reverse proxy handles that. Any way to do this "comment out" or cancel lines with .env?

@mnzaki
Copy link
Author

mnzaki commented Mar 27, 2023

@maltokyo one way would be to also put those ports in the .env file and change the docker-compose.yml to bind them to whatever is in .env

ports:
  - "${PUBLIC_HTTP_PORT}:80"
  - "${PUBLIC_HTTPS_PORT}:443"

Unfortunately I don't know of anyway to fully remove the port binding

Copy link

@silviot silviot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had the same thoughts reading the README.

I think this PR should also change this paragraph of the README.

Note that I'm not affiliated with the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants