Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allowNTLMCredentialsForDomains option to enterprise config file #1402

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sliezz
Copy link

@sliezz sliezz commented Jan 5, 2025

This PR add an ability to system administrators of configuring NTLM Credentials for domains without recompiling Zulip Desktop сlient app.

There is an Electron demand to implicity configure a list of servers for which integrated authentication is enabled.
Electon docs

In fact It useful only in an Enterprise environments I think we should configure it in appropriate config file

Fixes:

  • add option allowNTLMCredentialsForDomains to "Zulip-Desktop-Config/global_config.json"
  • on app init it checks up server list and send it to Electron

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (Ubuntu)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants