add allowNTLMCredentialsForDomains
option to enterprise config file
#1402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add an ability to system administrators of configuring NTLM Credentials for domains without recompiling Zulip Desktop сlient app.
There is an Electron demand to implicity configure a list of servers for which integrated authentication is enabled.
Electon docs
In fact It useful only in an Enterprise environments I think we should configure it in appropriate config file
Fixes:
allowNTLMCredentialsForDomains
to "Zulip-Desktop-Config/global_config.json"Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: