Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check user-groups permissions before offering "Mark as resolved" #1159

Open
chrisbobbe opened this issue Dec 14, 2024 · 1 comment
Open

Check user-groups permissions before offering "Mark as resolved" #1159

chrisbobbe opened this issue Dec 14, 2024 · 1 comment
Labels
a-api Implementing specific parts of the Zulip server API

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 14, 2024

From the Help Center doc on the "Mark as resolved" feature:

https://zulip.com/help/resolve-a-topic

Users can resolve and unresolve a topic if they have permission to edit topics. Organization administrators can configure who can edit topics.

If the user doesn't have permission to resolve/unresolve a topic, we shouldn't offer the button for it, because it takes up space and will always show a server error when they tap it (maybe after making them wait a while on a slow connection).

I've left this out of my work on #744 for expediency; the button is just always offered. The client-side permission check is also not implemented in the legacy RN app.

We're transitioning to a new permissions system based on user groups:

Let's plan to implement this just in that new system, skipping the old system, so we don't have to implement it twice. That'll just mean giving the same behavior as the legacy RN app until the server is upgraded to version 10 or later.

@chrisbobbe chrisbobbe added the a-api Implementing specific parts of the Zulip server API label Dec 14, 2024
@chrisbobbe chrisbobbe added this to the M6: Post-launch milestone Dec 14, 2024
@alya
Copy link
Collaborator

alya commented Dec 17, 2024

Note the ongoing work to build a dedicated permission: zulip/zulip#21811 / zulip/zulip#21811.

In the future, I expect this to additionally be controlled by a per-channel permission (details TBD).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: No status
Development

No branches or pull requests

2 participants