Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI broken at flutter precache step #1177

Closed
gnprice opened this issue Dec 19, 2024 · 1 comment · Fixed by #1176 or #1186
Closed

CI broken at flutter precache step #1177

gnprice opened this issue Dec 19, 2024 · 1 comment · Fixed by #1176 or #1186
Assignees
Labels
a-tools Our own development tooling, scripts, and infrastructure upstream Would benefit from work in Flutter or another upstream
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Dec 19, 2024

CI is failing, starting earlier today (example), with the following:

Run flutter precache --universal
  flutter precache --universal
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.13-11/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.13-11/x64
fatal: Not a valid object name upstream/master

This appears to be a regression introduced as part of the merge of the engine repo into the main/framework repo upstream:

by an assumption that the latest Flutter version can be found at upstream/master. We clone the repo as a remote named origin (the Git default) and with the branch main, which in the Flutter repo always points to the same commit as master.

@gnprice gnprice added a-tools Our own development tooling, scripts, and infrastructure upstream Would benefit from work in Flutter or another upstream labels Dec 19, 2024
@gnprice gnprice added this to the M5: Launch milestone Dec 19, 2024
@gnprice gnprice self-assigned this Dec 19, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 19, 2024
@gnprice
Copy link
Member Author

gnprice commented Dec 19, 2024

This has reappeared with a slightly different symptom (example):

Run flutter precache --universal
  flutter precache --universal
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.13-11/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.13-11/x64
fatal: Not a valid object name origin/master

The upstream script now assumes it can find the latest Flutter version at either upstream/master or origin/master. We still need a version of the workaround in #1176, because we clone the repo with the branch main, which in the Flutter repo always points to the same commit as master.

The reason the issue reappeared is that the upstream PR addressing this last night (flutter/flutter#160574) defeated our original hacky workaround in #1176: it looks for an actual remote named upstream, and when that's not found it looks at origin/master.

@gnprice gnprice reopened this Dec 19, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Flutter app Dec 19, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 19, 2024
Fixes zulip#1177, take 2.

The original hacky workaround subsequently broke after the upstream
change that fixed the "upstream" vs. "origin" part of the issue.
We still need a version of this workaround, though, because we
clone the repo with the branch `main`, which in the Flutter repo
always points to the same commit as `master`.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Flutter app Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-tools Our own development tooling, scripts, and infrastructure upstream Would benefit from work in Flutter or another upstream
Projects
Status: Done
1 participant