Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap target for channel in recipient header is shorter than header #1179

Open
gnprice opened this issue Dec 19, 2024 · 2 comments
Open

Tap target for channel in recipient header is shorter than header #1179

gnprice opened this issue Dec 19, 2024 · 2 comments
Labels
a-msglist The message-list screen, except what's label:a-content help wanted

Comments

@gnprice
Copy link
Member

gnprice commented Dec 19, 2024

When a channel message appears in a multi-channel narrow (like the combined feed), the recipient header has the channel name as well as topic.

Expected: Tapping anywhere in the channel part of the header should lead to the channel narrow.

Actual: Tapping directly on the text of the channel name leads to the channel narrow. But tapping slightly above or below leads instead to the topic narrow.

@gnprice gnprice added help wanted a-msglist The message-list screen, except what's label:a-content labels Dec 19, 2024
@gnprice gnprice added this to the M6: Post-launch milestone Dec 19, 2024
@aurora500
Copy link

I would like to contribute to this issue,kindly assign me

The problem is that the entire recipient header (including the channel area) is wrapped in a single GestureDetector that navigates to the topic narrow. We need to properly separate the gesture areas for the channel and topic sections.

@aurora500
Copy link

aurora500 commented Dec 21, 2024

Here is solution Proof of Concept of the above issue:

solutionPoc.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content help wanted
Projects
Status: No status
Development

No branches or pull requests

2 participants